Beauttie and Maha #25
Conversation
There was a problem hiding this comment.
Adagrams
Major Learning Goals/Code Review
| Criteria | yes/no, and optionally any details/lines of code to reference |
|---|---|
| Correctly creates and calls methods with proper syntax (parameters, return statements, etc.) | ✔️ |
| Uses correct syntax for conditional logic and iteration | ✔️ |
| Practices git with at least 3 small commits and meaningful commit messages | ✔️ |
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures |
✔️ |
| Practices pair programming; the reflection question on pair programming is answered | ✔️ |
Functional Requirements
| Functional Requirement | yes/no |
|---|---|
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) |
✔️ |
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass |
✔️ |
Utilizes unit tests to verify code; all tests for score_word pass |
✔️ |
Utilizes unit tests to verify code; all tests for highest_score_from pass |
✔️ |
Overall Feedback
Great work on this project! It is clear that the learning goals around manipulating data and writing methods were met. You've made good use of enumerables to work through some tricky logic and hashes to store the relevant data. Your code is clear and readable. Keep up the hard work!
| Overall Feedback | Criteria | yes/no |
|---|---|---|
| Green (Meets/Exceeds Standards) | 4+ in Code Review && 3+ in Functional Requirements | ✔️ |
| Yellow (Approaches Standards) | 3+ in Code Review && 2+ in Functional Requirements | |
| Red (Not at Standard) | 0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging |
Code Style Bonus Awards
Was the code particularly impressive in code style for any of these reasons (or more...?)
| Quality | Yes? |
|---|---|
| Perfect Indentation | ✅ |
| Elegant/Clever | ✅ |
| Descriptive/Readable | ✅ |
| Concise | ✅ |
| Logical/Organized | ✅ |
|
|
||
| # Wave 3 | ||
| def score_word(word) | ||
| score_chart = { |
There was a problem hiding this comment.
Great use of a hash to store this data
| word: words[scores.index(max_score)], | ||
| score: max_score | ||
| } | ||
| else |
There was a problem hiding this comment.
Nice work working through this tiebreaking logic with the help of some enumerable methods. Consider breaking out this logic into its own method.
| def is_in_english_dict?(input) | ||
| dictionary = CSV.read('assets/dictionary-english.csv', headers: true).map { |word| word["Word"] } | ||
|
|
||
| return dictionary.include?(input.downcase) |
There was a problem hiding this comment.
Nice work using .include? to directly return a boolean value.
Assignment Submission: Adagrams
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
What are the advantages of using git when collaboratively working on one code base? |
To be able to collaborate and see the reflected changes in the code.
What kind of relationship did you and your pair have with the unit tests? |
We did not use the unit tests.
Does your code use any methods from the
Enumerablemixin? If so, where and why was it helpful? |Yes we used .map .max .min .each .flatmap .delete_at
What was one method you and your pair used to debug code? |
We used repl irb to test whether the method was returning the correct score and later the correct word with the highest score given a tie.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? |
We discussed the ask/guess culture and talked through our preferences when it comes to giving/receiving feedback.